RUBY-3667 BSON::ObjectId(object_id) returns its argument when it is already an ObjectId#374
Merged
Merged
Conversation
…lready an ObjectId
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the BSON::ObjectId(...) convenience constructor to avoid unnecessary string conversion + re-parsing when the argument is already a BSON::ObjectId, preserving object identity and reducing overhead.
Changes:
- Make
BSON::ObjectId(object_id)returnobject_iddirectly when it is already aBSON::ObjectId. - Update YARD documentation for
BSON::ObjectId(...)to describe the expanded accepted input type. - Extend the top-level
BSONspec to assert identity preservation for existingBSON::ObjectIdinputs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spec/bson_spec.rb | Adds coverage that BSON::ObjectId(existing_object_id) returns the same instance, and scopes the existing string case into its own context. |
| lib/bson.rb | Implements early return for BSON::ObjectId arguments and updates method documentation accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
comandeo-mongo
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When given an existing ObjectId,
BSON::ObjectId(object_id)should simply return its argument, rather than converting it to a string and reparsing it.Thank you to @johnnyshields for the implementation.